Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): passwordless #14032

Merged
merged 27 commits into from
Nov 23, 2024
Merged

feat(auth): passwordless #14032

merged 27 commits into from
Nov 23, 2024

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Nov 22, 2024 •
edited
Loading

Description of changes

The purpose of this pull request is to add support for passwordless sign in / sign up functionality.

Test Run: https://github.com/aws-amplify/amplify-js/actions/runs/11980650141?pr=14032

Issue #, if available

Description of how you validated changes

  • manual testing
  • unit testing
  • integration testing

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jjarvisp and others added 24 commits November 1, 2024 16:07
@jjarvisp
chore: disable dependency review
3dbc288
@jjarvisp
feat(auth): associateWebAuthnCredential API (#1)
a39c93f
@jjarvisp
feat(auth): signIn with a webauthn credential (#3)
048eff1 
wip
@scanlonp @jjarvisp
feat(auth): listWebAuthnCredentials API (#6)
622b641
@scanlonp @jjarvisp
feat(auth): deleteWebAuthnCredential API (#8)
f0f2c7c
@yuhengshs @jjarvisp
feat(auth): Added signInWithUserAuth for password-less Sign-In (#2)
036a4a6
@jjarvisp
feat(auth): Add USER_AUTH flow in Sign Up logic (#11)
9a8ab67
@jjarvisp
feat(auth): enable autoSignIn support for passwordless (#7)
6e4f394
@jjarvisp
tmp disable code ql
b6e092c
@jjarvisp
handle SMS_OTP sign in result
c838e1f
@jjarvisp
cache session from signup and confirmsignup both
0589210
@jjarvisp
add getSignInResult test
9a3faf2
@jjarvisp
bundle size tests
a7cad01
@jjarvisp
Merge pull request #13 from jjarvisp/feat/pwless-testing
980d3b0 
feat(auth): passwordless changes
@jjarvisp
feat(passwordless): refactor to support new Cognito API changes (#14)
cac2f28 
* refactor to support new APIs

* bundle size updates
@jjarvisp
update exception mapping (#15)
c5b42e0
@jjarvisp
feat(auth): passwordless webauthn ceremony errors (#16)
b6b474c 
* update exception mapping

* update passkey error handling

* update tests

* bundle size tests

* simplify language

* refine error messages
@jjarvisp
fix(auth): clear auto sign in store on sign in (#18)
19519f2 
* fix(auth): clear auto sign in store on sign in

* add unit test
@jjarvisp
feat(auth): refactor foundational APIs to not access singleton (#17)
58a8650 
* enable ssr list and delete web authn credentials

* update unit tests

* add foundation tests

* revert: expose server APIs
@jjarvisp
feat(auth): passwordless - enable test specs / push trigger (#19)
34c5743 
* enable test specs / push trigger

* check for PublicKeyCredential

* bundle size tests

* fix recovery suggestion language

* align assertion with expected type

* fix tsdocs
@jjarvisp
Merge branch main into feat/passwordless
437fc68
@jjarvisp
bundle size updates
6fadcdf
@jjarvisp
fix(auth): passwordless pr feedback (#22)
b253166 
* callout in ts docs for password requirement

* unify callback and store reset for autosignin

* comment for clarity
@jjarvisp
enable integ tests
b66249d
@jjarvisp jjarvisp requested a review from a team as a code owner November 22, 2024 18:21
@github-actions GitHub Actions
Copy link

⚠️ This PR includes changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not manually change "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library
  • Remove any export paths without a major version bump

A repository administrator is required to review this change.

HuiSF
HuiSF previously approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@HuiSF HuiSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort, thanks!

@ashika112
Copy link
Member

Great work everyone! Thanks

@jjarvisp jjarvisp merged commit 68c7f6f into main Nov 23, 2024
30 checks passed
@jjarvisp jjarvisp deleted the feat/passwordless branch November 23, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashika112 ashika112 ashika112 approved these changes

@HuiSF HuiSF HuiSF approved these changes

@haverchuck haverchuck Awaiting requested review from haverchuck haverchuck is a code owner

@cshfang cshfang Awaiting requested review from cshfang cshfang is a code owner

@pranavosu pranavosu Awaiting requested review from pranavosu pranavosu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjarvisp @ashika112 @HuiSF @scanlonp @yuhengshs